Skip to content

Version bump of studio-frontend.#24677

Merged
attiyaIshaque merged 1 commit intoopen-release/juniper.masterfrom
attiya/YONK-1759
Aug 6, 2020
Merged

Version bump of studio-frontend.#24677
attiyaIshaque merged 1 commit intoopen-release/juniper.masterfrom
attiya/YONK-1759

Conversation

@attiyaIshaque
Copy link
Contributor

No description provided.

@nedbat nedbat changed the title [YONK-1759] Version bump of studio-frontend. Version bump of studio-frontend. Aug 4, 2020
@attiyaIshaque
Copy link
Contributor Author

@nedbat @fysheets Can you guys please tell me two points?

  • Why travis tests were not running on my PR? I have checked it in the recent PR's of juniper.master (tests were not being run on it). Is it okay to merge this PR without running the test?
  • Do we need to cherry pick this fix master as well?

@nedbat
Copy link
Contributor

nedbat commented Aug 5, 2020

About master: shouldn't this fix be put on master first, and then backported to Juniper (and Ironwood)? I'm not sure what the usual process is for getting this deployed on master, but we definitely don't want Juniper to be ahead of master.

@attiyaIshaque attiyaIshaque changed the base branch from open-release/juniper.master to master August 6, 2020 07:23
@attiyaIshaque attiyaIshaque changed the base branch from master to open-release/juniper.master August 6, 2020 07:23
@attiyaIshaque
Copy link
Contributor Author

@nedbat Should I close this PR and create a new one against master? Or Merge this PR and cherry pick these changes into master?

@nedbat
Copy link
Contributor

nedbat commented Aug 6, 2020

I don't have a strong preference. The usual approach is to update master, and then consider whether it should be picked over to Juniper.

@attiyaIshaque
Copy link
Contributor Author

attiyaIshaque commented Aug 6, 2020

@nedbat Okay. I am going to merge this PR then and will then cherry pick this commit into master.

@attiyaIshaque attiyaIshaque merged commit 47ab6af into open-release/juniper.master Aug 6, 2020
@attiyaIshaque attiyaIshaque deleted the attiya/YONK-1759 branch August 6, 2020 12:59
@attiyaIshaque
Copy link
Contributor Author

I have cherry pick these changes into master. https://github.com/edx/edx-platform/pull/24723

lgp171188 pushed a commit to open-craft/openedx-platform that referenced this pull request Aug 20, 2020
ztraboo pushed a commit to CUCWD/edx-platform that referenced this pull request May 27, 2021
shadinaif added a commit to appsembler/edx-platform that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants